# \[Auto\] Merge Status

**URL:** <https://community.zeek.org/t/auto-merge-status/2906>\
**Category:** Development\
**Tags:** development\
**Created:** [November 18, 2013, 3:52pm UTC](https://community.zeek.org/t/auto-merge-status/2906 "2013-11-18T15:52:18Z")\
**Posts on this page:** 5\
**Page:** 1

<div class="post-metadata">

**Author:** ![robin](https://yyz1.discourse-cdn.com/flex011/user_avatar/community.zeek.org/robin/32/599_2.png) [@robin](https://community.zeek.org/u/robin)\
**Post date:** [November 18, 2013, 3:52pm UTC](https://community.zeek.org/t/auto-merge-status/2906/1 "2013-11-18T15:52:18Z")

</div>

Daniel, rathter than simply removing the piece of code, can we put in  
a 2.2 version instead to achieve the same effect?

Robin

---

<div class="post-metadata">

**Author:** ![Daniel\_Thayer](https://avatars.discourse-cdn.com/v4/letter/d/8dc957/32.png) [@Daniel\_Thayer](https://community.zeek.org/u/Daniel_Thayer)\
**Post date:** [November 18, 2013, 7:05pm UTC](https://community.zeek.org/t/auto-merge-status/2906/2 "2013-11-18T19:05:44Z")

</div>

I think it's a bad idea to have script code in local.bro (besides  
"@load") because it will not be updated when a user upgrades to a  
newer release of Bro. Also, the fact that it's commented-out by  
default means it's not going to be tested, and most likely nobody  
will notice (for a while) when something else changes that breaks  
that code.

Perhaps instead we could put something in scripts/policy/misc/ (or  
somewhere else?), and then @load that from local.bro (the @load  
would be commented-out by default).

---

<div class="post-metadata">

**Author:** ![Siwek\_Jon](https://avatars.discourse-cdn.com/v4/letter/s/90db22/32.png) [@Siwek\_Jon](https://community.zeek.org/u/Siwek_Jon)\
**Post date:** [November 18, 2013, 7:28pm UTC](https://community.zeek.org/t/auto-merge-status/2906/3 "2013-11-18T19:28:36Z")

</div>

Even though the example would be commented out, that's defying the “best practice” of the only code in local.bro being @loads — it generally simplifies the upgrade procedure both for a user that wants to use the new upstream version and for a dev/maintainer that wants to set new defaults for things.

Maybe putting the example closer to the Notice::policy documentation (either within the Broxygen comments or the general Notice Framework docs) is better. There, it’s easier to regression test, more likely to be changed if a dev makes incompatible changes to notice scripts, and more accessible to users.

- Jon

---

<div class="post-metadata">

**Author:** ![robin](https://yyz1.discourse-cdn.com/flex011/user_avatar/community.zeek.org/robin/32/599_2.png) [@robin](https://community.zeek.org/u/robin)\
**Post date:** [November 18, 2013, 10:04pm UTC](https://community.zeek.org/t/auto-merge-status/2906/4 "2013-11-18T22:04:32Z")

</div>

Ok, makes sense to leave it out of local.bro. Whether to put it  
elsewhere depends on how many people might actually use it I guess.  
I'll merge as is for now.

Robin

---

<div class="post-metadata">

**Author:** ![system](https://canada1.discourse-cdn.com/flex011/uploads/zeek/original/1X/f09d732bc2cc7c7cc7e35db67cf4e1d5233ce7a7.png) [@system](https://community.zeek.org/u/system)\
**Post date:** [May 6, 2022, 3:41pm UTC](https://community.zeek.org/t/auto-merge-status/2906/5 "2022-05-06T15:41:23Z")

</div>


