[Bro-Commits] [git/broctl] fastpath: Fix various bugs and remove some unused code (7108ea6)

Development
#1

There are two problems with this patch:

    - you're removing some parts from the plugin api that I think
      should stay. Just that it's not used currently doesn't mean it
      can't; that's what plugins are for. If it breaks the test plugin
      the bug is in there. And if somethign doesn't get called
      (cmd_restart_*) we should add the calls.

    - completedefault() is actually used, it's part of the Cmd API,
      see 23.1. cmd — Support for line-oriented command interpreters — Python 2.7.18 documentation. Better to fix the
      method than to remove.

So I've turned these changes into a branch for now
(topic/dnthayer/cleanup) and reverted the commit on fastpath.

Robin

#2

I removed some code because:

- The cmd_restart_* are not actually called anywhere, and the
   documentation says, "Finally, note that the restart command
   doesn’t have its own method as it’s just a combination of
   other commands and thus their callbacks are run."

- The part that was crashing the TestPlugin.py was due to an
   extra cmd-line parameter "-p" to the "scripts" command
   that was removed a long time ago.

#3

- The cmd_restart_* are not actually called anywhere, and the
  documentation says, "Finally, note that the restart command
  doesn’t have its own method as it’s just a combination of
  other commands and thus their callbacks are run."

Oh, that sounds like that unfortunate documentation. :slight_smile: I don't see
anything wrong with providing the restart function, it might be handy
for some cases. Please see if you can add the calls (maybe I'm missing
something and there's a reason for the docs saying that; if so, please
let me know if you run into trouble)

- The part that was crashing the TestPlugin.py was due to an
  extra cmd-line parameter "-p" to the "scripts" command
  that was removed a long time ago.

Ok, I missed that we have removed that option, so that's ok then.

Robin

#4