[Bro-Commits] [git/bro] fastpath: Change X509 extension value parsing to not abort on malloc failures. (385438d)

Development
1

+ // TODO: see about using regular malloc here, there were unknown problems
+ // using anything other than OPENSSL_malloc that need investigation.
+ char* buffer = (char*) OPENSSL_malloc(length);

Johanna, do you know any more details of what was wrong w/ regular malloc() here? I think it makes sense to get away from using OpenSSL’s malloc wrapper if it’s possible.

If I change it, running the test suites on OS X don’t show a problem. Is triggering the problem more subtle than the test suites will pick up on?

- Jon

2

Nah, it was fairly obvious. I might just have done something else wrong and blamed it on that - if everything still works, that should be good enough :slight_smile:

Johanna

3

Thanks, I’ll make the change after this one gets reviewed/promoted.

- Jon