Fixing unit tests.
Sorry for the direct master commit, but test fixes I did before kept lagging behind other new commits such that they were failing again by the time they were merged. Right now all the unit tests pass for me (except for notice.suppression-disable intermittently failing, which I'll try to fix later). Does everyone else see the same thing?
- Jon
Woo! I see the same thing. It looks like the baseline for notice.suppression-disable is old, want me to just update it? (I haven't run the external tests either yet)
.Seth
Woo! I see the same thing. It looks like the baseline for notice.suppression-disable is old, want me to just update it?
What I see for that test is that sometimes it passes and sometimes not, and that was because the notice_policy.log ordering isn't deterministic (there's another thread in bro-dev about it).
- Jon
Ah, of course. I forgot about that thread.
.Seth