[Bro-Commits] [git/bro] master: Modification to the Communication framework API. (da9b8cc)

Development
1

It seems that this change causes Bro to fail to start (due to 'listen_port_clear'
in aux/broctl/BroControl/install.py)

-Daniel

2

Did you make sure the submodules are all at the correct state? Try

    git submodule update --recursive --init

Robin

3

Yes, I tried that (didn't seem to make any difference).
I also started with a fresh copy of the sources:

$ git clone --recursive ssh://git@git.bro-ids.org/bro
$ grep -R listen_port_clear bro
bro/aux/broctl/BroControl/install.py: print >>out, "redef Communication::listen_port_clear = %s/tcp;" % nextPort(manager)

After building and installing Bro, I did this:

$ broctl
[BroControl] > install
[BroControl] > start
starting bro ...
bro terminated immediately after starting; check output with "diag"
[BroControl] > diag

==== stderr.log
error in /myprefix/spool/policy/auto/standalone-layout.bro, line 2: "redef" used but not previously defined (Communication::listen_port_clear)

4

Ugh, sorry about that. It'll be fixed when you pull and update your submodules. Thanks for catching that.
  
  .Seth

5

Now I'm wondering why it was working fine for me ... Odd.

Robin

6

Ugh, sorry about that. It'll be fixed when you pull and update your submodules. Thanks for catching that.

Now I'm wondering why it was working fine for me ... Odd.

Maybe you hadn't done a `broctl install` yet and so everything still consistently used listen_port_clear?

- Jon

7

Actually I was pretty sure I did, but well, perhaps not.

Robin

8

I thought I did too. It's fixed now at least.

.Seth