FYI: Bro test suite fails with diff in FTP output

Hi,

FYI:
I just noticed that the bro test suite fails with the current trunk.
Seems like the FTP analyzer output changed.

cu
gregor

I just noticed that the bro test suite fails with the current trunk.

You mean 1.5.2.10? It worked for me this weekend (I checked prior to
committing the new stuff). What system are you running on?

    Vern

I just noticed that the bro test suite fails with the current trunk.

You mean 1.5.2.10?

yes.

It worked for me this weekend (I checked prior to
committing the new stuff). What system are you running on?

That was on ashcloud.
Do I need to use any particular configure options? I just used a "plain"
configure without any options....

cu
Gregor

That was on ashcloud.
Do I need to use any particular configure options? I just used a "plain"
configure without any options....

You shouldn't. I'll take a look at this.

    Vern

That was on ashcloud.
Do I need to use any particular configure options? I just used a "plain"
configure without any options....

Okay, I've tracked this down. The problem is that my Mac environments
have support for libmagic, while ashcloud does not. So when the test suite
was generated, it had file-type identification, but when run on ashcloud,
the results don't.

I'm inclined not to fix this right now, since I gather the plan is to
revamp the whole testing framework. If I'm wrong about that, though, then
we need to brainstorm about the best fix.

    Vern

Yes, makes sense.

A quick hack we could perhaps still do is add at least a warning
flagging that Bro is running with a different configure set than
when the baseline was generated. Shouldn't be too difficult by
comparing relevant pieces of config.h .

Robin

A quick hack we could perhaps still do is add at least a warning
flagging that Bro is running with a different configure set than
when the baseline was generated. Shouldn't be too difficult by
comparing relevant pieces of config.h .

That's a good thought. These config-based differences can eat up
a bunch of time if unrecognized as such.

    Vern