[REL - 10amd64-default][security/bro] Failed for bro-2.2 in build

Development
1

Sounds like FreeBSD has upgraded to a newer version of clang and it
doesn't like to build /src/logging/writers/SQLite.cc anymore. It's the
last few lines of the attached message that shows the problem, is there
an obvious fix?

Thanks!

    Craig

[REL - 10amd64-default][security/bro] Failed for bro-2_2 inbuild.eml (53.7 KB)

2

Which clang version is this? I've tried it with a recent version of
the clang 3.4 release branch, and that works fine for me.

But based on the error message, I'm attaching a patch; does that help
by any chance?

Robin

patch (616 Bytes)

3

Which clang version is this? I've tried it with a recent version of
the clang 3.4 release branch, and that works fine for me.

I dunno, I've asked them them to include the clang version before; I'll
ask again.

But based on the error message, I'm attaching a patch; does that help
by any chance?

I'll see if I can get someone to test it. Thanks!

    Craig

4

Which clang version is this? I've tried it with a recent version of
the clang 3.4 release branch, and that works fine for me.

But based on the error message, I'm attaching a patch; does that help
by any chance?

I submitted a PR with your patch and it worked (thanks!).

Here's some feedback:

- The SQLite.cc change also needs to be applied to
   src/input/readers/Raw.cc and src/input/readers/SQLite.cc. Please
   upstream that as you see fit.

- You didn't manage to reproduce the build failures locally because
   it's an issue caused by libc++, not clang. If you build with clang
   but still use libstdc++, everything works as expected.

    Craig