I took a few notes of the rules of thumb that I try to use for the base/ scripts directory. Let me know if there are questions or thoughts about other rules for these scripts.
http://bro-ids.org/development/script-conventions.html#rules-for-base
.Seth
Is that actually supposed to be the thing about making options that alter script behavior be consts with &redefs as opposed to globals to prevent runtime modification? Because there’s places where it makes sense for something to be const without &redef. E.g.: module Math; export { const PI = 3.14; } Scripts in base/protocols (dns/syslog/ssl/modbus/socks) have consts of that style. Jon
Damn, you're right. I'll reword that a bit tonight or remove it. Thanks for looking over the list.
.Seth