Where did the min() function go?

Hi,

I'm having a weird problem. The min() inline function is gone from
master. It's still used by a bunch of files that still compile, so there
must be a C++ builtin, macro, or whatever. I just can't find it where is
it?

I noticed that when trying to merge master into my rpc/nfs branch. I'm
using min() to and it seem that the signature I use is not supported by
the the current version of min.....

BTW, the min() inlines where removed by this commit (in my actual patch
I added overloaded min() functions but they didn't make it to master,
presumably due to the cleanup)

commit 714289bd1354f5ab62b87e7ae86592ad70414746
Author: Robin Sommer <robin@icir.org>

    Changing the HTTP's analyzers internals to use 64-bit integers.
    (Gregor Maier).

    This is the patch from #326, plus some cleanup.

cu
Gregor

well, of course I find out myself as soon as I hit send....

min() is an STL algorithm. But I guess that means that
#include <algorithm> should now be added to util.h, right? (that's
where the min functions used to live)

cu
gregor

min() is an STL algorithm. But I guess that means that
#include <algorithm> should now be added to util.h, right? (that's
where the min functions used to live)

It might just be my personal style, but I like it when source files include all headers it requires and no more; not requiring some include cascade to get things to work. And I don't think util.h has any dependence on <algorithm>, so I'd say just add <algorithm> to files that generate compile errors because it's missing as you find them.

There was another issue going on with using the templated std::min() with args of differing types that I address in commit 35b7caf44fdb045e2e729cfbf6f84fde707985db

- Jon

any dependence on <algorithm>, so I'd say just add <algorithm> to
files that generate compile errors because it's missing as you find
them.

Ack.

with args of differing types that I address in commit
35b7caf44fdb045e2e729cfbf6f84fde707985db

Merged, thanks.

Robin