[Bro-Commits] [git/bro] topic/robin/plugins: Lots of cleanup and API documentation for the analyzer/* classes. (e0c4bd1)

I don't think we need them. The original reason for them was for your old multicore work, right?

  .Seth

No, it was just an alternative way of disabling chunks of analyses
(for load-levels I believe, though I don't actually remember).

Btw, I'd appreciate any feedback on this branch if anybody is game to
take a look. The main action is in src/{analyzer,plugin,protocols}/*
and scripts/base/frameworks/analyzer/*

Robin

No, it was just an alternative way of disabling chunks of analyses
(for load-levels I believe, though I don't actually remember).

Ahh. I think the new approach of just disabling entire analyzers will be more straightforward although I see the desire for the attribute because it could make things even more flexible but I don't think it's necessary.

Btw, I'd appreciate any feedback on this branch if anybody is game to
take a look. The main action is in src/{analyzer,plugin,protocols}/*
and scripts/base/frameworks/analyzer/*

I'll start playing with it soon.

  .Seth

Yeah, for example one could turn off http_reply but not http_request.
I'm fine either way, it's not a big deal to keep ot if we think it's
still useful.

Robin

Yep, it's probably better overall if we stay away from the notion of disabling analyzers in parts. Having the foundation that analyzers are either fully on or fully off is a nice thing to be able to assume.

  .Seth