2.6-beta build error

I’m hitting the same error when trying to build release/2.6 or master:

[ 99%] In file included from /usr/local/src/bro/src/Func.cc:702:0:
bro.bif: In constructor ‘MMDB::MMDB(const char*, stat)’:
bro.bif:3630:47: error: cannot convert ‘stat’ to ‘__dev_t {aka long unsigned int}’ in initialization

CentOS Linux release 7.5.1804

Let me know if you need any other information. As a point of comparison, bro-2.5-897 builds fine.


Looks like travis-ci didn't catch this because the travis-job script does not install libmaxminddb-devel/libmaxminddb-dev
so bro is not built with mmdb support.

Thanks, it's fixed by a simple patch [1] now in master.

- Jon

[1] https://github.com/bro/bro/commit/d7097635f4b1ec9adca548b81ee42968629987a5

That fixed the build, but I think I found a new issue.

If bro is built with maxminddb support but the db files are not present yet, bro logs this twice for each connection:

1537548892.975875 Reporter::ERROR Failed to open GeoIP location database (lookup_location(Conn::c$id$resp_h)) /srv/bro/spool/installed-scripts-do-not-touch/site/ncsa/./bro-scripts/./conn-add-geodata.bro, line 23
1537548892.978846 Reporter::ERROR Failed to open GeoIP location database (lookup_location(Conn::c$id$orig_h)) /srv/bro/spool/installed-scripts-do-not-touch/site/ncsa/./bro-scripts/./conn-add-geodata.bro, line 19

I think I remember the older geoip bifs logging this as well, but only once at startup, not once per call to lookup_location.

Yes, looks like it used to be that way. Changed via [1] now in master.

- Jon

[1] https://github.com/bro/bro/commit/2ede95422bab0c4853b8db7cc15fe5c6e77aa75a