bro-pkg -> bropkg

What does everyone think about making a change to rename bro-pkg to bropkg? I think we're early enough that we could probably get away with it and it fits with more with existing tools like broctl. I find it difficult to type the hyphen too for some reason.

Thoughts?

  .Seth

Someone did come up to me and ask about that during BroCon.

I am indifferent, just please let’s not open up the whole tool name naming conversation. I don’t think I can take that again. :slight_smile:

Either way seems fine to me also. Maybe do a strawpoll and go w/ the majority. Other misc. thoughts:

Internally, I already used “bropkg” instead of “bro-pkg” for the name of the Python package/API because Python discourages use of hyphens in module/package names. But using the Python API isn’t a common use case and figure most devs can handle doing “import bropkg” even though the command-line tool is named “bro-pkg”.

I don’t think there’s an argument to change it for the sake of aligning the naming convention with “broctl” because there’s already "bro-cut”. The hyphenation between those tools is already inconsistent or at least unclear why one deserves hyphenation and the other doesn’t.

If easier typing is the rationale, users do already have the option of creating their own shell alias.

Another idea is to keep the command line tool named “bro-pkg”, but also install a symlink to it named “bropkg” for convenience.

- Jon

Bropkg is easier to type indeed. And then let’s change the brocut.

No strong preference either way on my end, but let's not touch bro-cut
please, that's used in too many scripts.

Robin

Bropkg is easier to type indeed. And then let's change the brocut.

Yeah, all bro* utils should be consistent. If we change bro-pkg, then
bro-cut must undergo the same changes.

Personally, I never had trouble typing "bro-pkg" though. Can we do a
Twitter poll to figure out what our users prefer?

    Matthias

No strong preference either way on my end, but let's not touch bro-cut
please, that's used in too many scripts.

I like Jon's idea to create a symlink for bro-pkg. One could also
install links for brocut and bro-ctl.

I like Jon's idea to create a symlink for bro-pkg. One could also
install links for brocut and bro-ctl.

    PREFIX/bin/bro
    PREFIX/bin/bro-ctl
    PREFIX/bin/broctl
    PREFIX/bin/bro-cut
    PREFIX/bin/brocut
    PREFIX/bin/bro-pkg
    PREFIX/bin/bropkg
    ..

That looks too confusing to me! My vote is to go with one scheme,
ideally the one that breaks less existing tooling.

    Matthias

Let's hold off if we might be renaming Bro

Yeah, I think changing bro-cut is too far gone at this point. I was only asking about bro-pkg because it's so new and so few people have it installed.

  .Seth

Quick follow up. I'm fine leaving things as-is. It's certainly easier and we can move on. :slight_smile:

  .Seth